pulibrary / bibdata

Local API for retrieving bibliographic and other useful data from Alma (Ruby 3.2.0, Rails 7.1.3.4)
BSD 2-Clause "Simplified" License
16 stars 7 forks source link

The build_items method needs to reference description instead of enumeration #1827

Open mzelesky opened 2 years ago

mzelesky commented 2 years ago

https://github.com/pulibrary/bibdata/blob/99f589ae48a2f71ddaf83afa264ed87a05e495ac/marc_to_solr/lib/process_holdings_helpers.rb#L144

In this line, it should say item[:description] instead of item[:enumeration].

sandbergja commented 2 years ago

In Alma publishing profile, there's a field called "description" that we bring in on the Enrichment tab. It includes both chronology and enumeration.

christinach commented 1 year ago

Update it as enum_chron in bibdata and Enumeration/Chronology in the requests form

kevinreiss commented 1 year ago

Update the label on the request form table to say "Enumeration and Chronology" and update the code's hash key to be [:enum_chron].

christinach commented 14 hours ago

Confirm with @mzelesky if the hash key will be :description or :enum_chron. Also look in the Orangelight agenda for related notes.

mzelesky commented 14 hours ago

enum_chron or description both work; what really matters is what displays.