Refactor `DumpType` to use configuration, not database - Githubissues

pulibrary / bibdata

Local API for retrieving bibliographic and other useful data from Alma (Ruby 3.1.0, Rails 7.1.3.4)

BSD 2-Clause "Simplified" License

16 stars 7 forks source link

Refactor `DumpType` to use configuration, not database #2348

Closed maxkadel closed 3 months ago

maxkadel commented 4 months ago

What maintenance needs to be done?

Refactor DumpType to use only configuration, not database tables.

Level of urgency

[ ] High
[x] Moderate
[ ] Low

Why is this maintenance needed?

This class is mostly used in categorizing dumps, and retrieving them. The DumpType table is only 7 lines long and never changes, which means it behaves more like configuration,
We are seeing errors in using the database table, including in the SQS Poller (see Princeton Ansible PR for changes to Postgres config to try to fix this), and with 15 minute database queries against this table (See Bibdata issue)

Acceptance criteria

[ ] The code does not try to retrieve data from the DumpType table in Postgres
[ ] New and old events still have the correct "Dump Type" in the UI
[ ] Tests continue to pass
[ ] Make rollback as easy as possible (aka, don't immediately drop the table on first deploy without a plan for if something goes wrong)

Implementation notes, if any

maxkadel commented 4 months ago

Investígate changing DumpType to enum