"computer network resources" are being misclassified as primary sources - Githubissues

pulibrary / bibdata

Local API for retrieving bibliographic and other useful data from Alma (Ruby 3.2.0, Rails 7.1.3.4)

BSD 2-Clause "Simplified" License

16 stars 7 forks source link

"computer network resources" are being misclassified as primary sources #2528

Closed sandbergja closed 1 month ago

sandbergja commented 1 month ago

Expected behavior

"computer network resources" are not considered to be primary sources unless they have one of the primary source genres in the record.

Actual behavior

They are included -- I think because the word "resources" contains the word "sources". See MMS ID 99125445731306421 as an example.

Steps to replicate

Go to https://catalog.princeton.edu/catalog?f%5Bgenre_facet%5D%5B%5D=Primary+source&search_field=all_fields&q=id%3A99125445731306421 -- this should be empty

Impact of this bug

Primary source genre facet is less reliable.