Remove pickup_location_id and pickup_location_code fields from bibliographic/:id/holdings/:id/availability

[christinach]

child of #573

Alma doesn't use these.

example of previous values:

pickup_location_code: "fcirc",
pickup_location_id: 299,

Current mapping from voyager is in voyager_helpers https://github.com/pulibrary/voyager_helpers/blob/0ae062a25177187fb6b47ae19e29b45ea469acb0/lib/voyager_helpers/liberator.rb#L1325

https://github.com/pulibrary/requests/blob/91dfc63ae297183f478589c7764de67acf1519c4/app/models/requests/requestable/item.rb#L3

https://github.com/pulibrary/requests/blob/175199ffbfe321ee1de86bce21f11bc78fd827dd/app/models/concerns/requests/voyager.rb#L66

[christinach]

blocked by #844

[hackartisan]

Blocked by locations discussion.

[hackartisan]

@mzelesky This value powers the new pickup service implemented for covid. Can you help us figure out how this service will be impelmented in Alma?

[mzelesky]

I don't have all the details yet, but I think the major difference here is that Alma has the concept of locations being placed under libraries. Each library has a circulation desk.

There is also the concept of a 'fulfillment unit', which determines requesting behavior for groups of locations. These 2 configurations create an interplay that determines which library circulation desk can fulfill a request. Relevant documentation:

https://knowledge.exlibrisgroup.com/Alma/Product_Documentation/010Alma_Online_Help_(English)/030Fulfillment/080Configuring_Fulfillment/050Physical_Fulfillment

[hackartisan]

These values are now in use!

[jrgriffiniii]

@kevinreiss has confirmed that this has been resolved by previous work undertaken by @hectorcorrea

[hectorcorrea]

See https://github.com/pulibrary/bibdata/issues/1378