pulibrary / dpul

Princeton's digital collections: Digital PUL
https://dpul.princeton.edu/
Apache License 2.0
15 stars 0 forks source link

dpul:reindex:collections does not appear to fully reindex collections #1491

Closed kelea99 closed 6 months ago

kelea99 commented 7 months ago

Summary

Reported by @tventimi (#1488 ) and Ellen Ambrosone (SAE). may be similar to #1294 . maybe also look at #1395 , just in case.

Impact

Please include hard deadlines, if the exhibit is part of an event, the issue is stopping work, etc.

Priority recommendation

Sudden Priority Justification

Required if "asap" or "within the next 3 weeks" is checked. Add "Sudden Priority" and "Maintenance/Research labels Good to have everything fully available to folks by winter break, before we are a skeleton crew.

Researchers will use these collections over winter break and if this isn't fixed there will be missing content that will prevent them from finishing their research - and we won't have staff to perform the workaround.

Expected behaviour

Actual behaviour

Steps to reproduce behaviour

Go to the ukrainian-art collection, hit "reindex all", go to it in Figgy, compare the count of resources in each set of search results. They won't match. Check honeybadger? Check sidekiq? Check indexing errors in DPUL.

Screenshots

Examples

Figgy counts below are faceted to complete resources only.

Ukranian Art in Times of war (an ephemera project):

Treasures of the East Asian Library (a collection):

Slavic DPUL Exhibit (a collection):

sdellis commented 7 months ago

Reels of microfilm in Tom's collection don't seem to get indexed.

tpendragon commented 6 months ago

We're going to mark this as a sudden priority and work it, understanding that it might be hard to get it done in a specific timeline.

hackartisan commented 6 months ago

There's an indexing error from honeybadger that I'm not sure is related but I thought worth dropping a link. The collection producing those errors has a couple of reindexing attempts with status "not yet started" https://dpul.princeton.edu/ukrainian-art/dashboard

hackartisan commented 6 months ago

I just added some more specific links to the steps to reproduce. Currently the Ukraine art counts look right.

hackartisan commented 6 months ago

the redis port was closed on dpul1 and dpul2 could not connect. there were a bunch of errors related to this in datadog. This may have been the issue if dpul2 happened to be the machine that tried to enqueue the exhibit reindex. This has been resolved and I'll try reindexing the affected collections now.

hackartisan commented 6 months ago

All the counts for the collections cited are now correct. If any other counts seem off, reindexing the collection via the dpul admin interface should resolve it. We could kick off a reindex for all dpul collections. If that's desired, feel free to request it by reopening this ticket with a comment to that effect and I'll do it right away.