search

pulibrary / dpul

Princeton's digital collections: Digital PUL
https://dpul.princeton.edu/
Apache License 2.0
15 stars 0 forks source link

multiple description box entries from Figgy Ephemera are not viewing as separate paragraphs anymore in DPUL #1499

Closed kelea99 closed 4 months ago

kelea99 commented 5 months ago

Summary

related to number #1489

@hackartisan I know we tested this and it worked in DPUL. I wonder if multiple description boxes vs. testing two and two of different languages is what the issue is? Gilda has added multiple description boxes in Figgy for her ephemera items, in lieu of the carriage return work. They are all flowing together like a river. See screenshot below. Example DPUL: https://dpul.princeton.edu/woman-life-freedom-movement-iran-2022/catalog/02c8124b-5133-487e-9646-7896bba289a2 Figgy: https://figgy.princeton.edu/catalog/02c8124b-5133-487e-9646-7896bba289a2

Impact

Please include hard deadlines, if the exhibit is part of an event, the issue is stopping work, etc.

Priority recommendation

Sudden Priority Justification

Required if "asap" or "within the next 3 weeks" is checked. Add "Sudden Priority" and "Maintenance/Research labels Not a rush, but will need to be functional before gilda publishes the site that she is currently building. next 3 weeks would be ideal, but I can reach out to her for more specific launch date.

Expected behaviour

As a figgy data entry person for ephemera adding multiple description boxes to an ephemera folder, I expect each description box to be its own paragraph in DPUL.

Actual behaviour

All descriptions are flowing together in one paragraph in dpul.

Steps to reproduce behaviour

Screenshots

Screenshot 2024-01-12 at 9 47 20 AM (2) Screenshot 2024-01-12 at 9 47 12 AM (2)

kelea99 commented 5 months ago

@hackartisan, with gilda now. she will be ready to publish next week. can i get an eta for looking into this?

hackartisan commented 5 months ago

We'll look at this issue during maintenance planning today.

hackartisan commented 4 months ago

The more/less javascript is breaking it -- more / less needs to retain the list tags. probably should, use innerHTML and some parsing instead of text.

hackartisan commented 4 months ago

I'm unassigning myself; this branch has a minimal replicating test: https://github.com/pulibrary/dpul/compare/main...1499-multi-descriptions