search

pulibrary / dpul

Princeton's digital collections: Digital PUL
https://dpul.princeton.edu/
Apache License 2.0
15 stars 0 forks source link

Diacritics display issues reported for SAE items in transliterated SInhala #884

Open kelea99 opened 3 years ago

kelea99 commented 3 years ago

Ellen Ambrosone's collaborators in Sri Lanka brought to our attention that the diacritics are displaying incorrectly for them [in the search results/browse category listing of items]. Namely the half moon above the M (see screenshot) is causing problems. We do not yet know what browser they are using Ellen and I ran test locally. Ellen says its displaying funky in Edge (we tell folks not to use that). Here is what we found:

  1. Firefox (KEL) lists fine. the half moon is slightly off center in the item title and item metadata views, which may be a factor in the display issues for others?: listing, item title, item metadata
  2. safari (KEL) lists fine: listing, item metadata
  3. Chrome Version 89.0.4389.90 (Official Build) (x86_64) (KEL) same as firefox above. lists fine, slightly offcenter in item metadata and item title view: listing, item title, item metadata
  4. Chrome Version 89.0.4389.90 (Official Build) (64-bit) (Ellen A)problem: screenshot
kelea99 commented 3 years ago

update from Axa and Shaun, @escowles and @hackartisan. Axa thinks dpul is using dejavu fonts. Perhaps the sinhala subset isn’t included. Can you add a language attribute indicating the language and if it’s sinhala, use a font with that supports that subset: https://fonts.google.com/?subset=sinhala>

kelea99 commented 3 years ago

@hackartisan, is this a known issue?

hackartisan commented 3 years ago

@kelea99 I'm not sure what you're asking. To me, a known issue is a bug that has a ticket. So this ticket makes it a known issue. You must mean something else?

kelea99 commented 3 years ago

as in some diacritics display for some languages in general is a problem for applications (Plural) in web browsers.

hackartisan commented 3 years ago

Ah! I think Axa is probably right, that this is a fonts issue.

tpendragon commented 3 years ago

We've had to change font before for connecting characters, so we have to be careful not to reintroduce this:

https://github.com/pulibrary/dpul/issues/662

kelea99 commented 3 years ago

@hackartisan this ticket should be addressed only after upgrade to Spotlight 3.0, along with all the other languages we support to make sure we don't break anything we've fixed before. see @tpendragon above

kelea99 commented 3 years ago

updated Ellen, to ensure she knows as well