pulibrary / dspace-development

DSpace infrastructure and development resources for the Princeton University Library.
https://dspace-development.readthedocs.io/en/latest/
1 stars 0 forks source link

OAR/DSpace: Incorrect counts for Collections #710

Closed hhkitsune closed 1 year ago

hhkitsune commented 1 year ago

Description:

The Departmental Collections page is showing incorrect counts for some of the collections. For example, Art & Archaeology is showing "0" but there are "26" items when you click the collection link and go to that collection's page.

Here is a list of the collections that need to be fixed:

Note: These are the count differences I found using the UI. However, the numbers should be checked internally to be certain all counts are made correct and no assets are missing from the collection display.

Acceptance Criteria:

hhkitsune commented 1 year ago

@jrgriffiniii FYI, this is the problem with OAR/DSpace I had mentioned in the meeting.

jrgriffiniii commented 1 year ago

This should also confirm that the results on the Collection show page are valid (the number on the page, as well as confirming that each member item is listed as they should be).

jrgriffiniii commented 1 year ago

The collection members are rendered using database queries within interfaces such as https://oar.princeton.edu/handle/88435/pr1mw2m (hence, these should be accurate), while the item count for the https://oar.princeton.edu/collection-list interface is populated using other mechanisms.

jrgriffiniii commented 1 year ago

https://github.com/PrincetonUniversityLibrary/princeton-5/tree/oar-TEST-fix-collection-count resolves most of this issue, however, there is still one final bug affecting the collection member item total within the Collection show page.

jrgriffiniii commented 1 year ago

I have been able to isolate https://github.com/PrincetonUniversityLibrary/princeton-5/commit/28d4c7dc4dc8584b3d56f506863e0573501b31fe#diff-b31192a1c4cab83405c6a20f9c6704c3dabe1a627ecb7efc67638497b51808bd as the area of the source code base where the query is failing (some time was consumed attempting to trace this through the logging). I am looking to try and implement a remedy for this now.

jrgriffiniii commented 1 year ago

While trying to resolve this as a bug, it appears that entirely rebuilding the Solr Index using ($ /dspace/bin/dspace index-discovery -b) is also going to be required.

jrgriffiniii commented 1 year ago

This is indeed what is going to be required for fully resolving this issue. I shall finalize this by opening pull requests for the source code changes.

jrgriffiniii commented 1 year ago

The reindexing is being finished for the deployments before this is shared for review with the stakeholders.

jrgriffiniii commented 1 year ago

For the production, staging, and development environments, the reindexing is now finished.