search

pulibrary / dspace-osti

Preparing PPPL dataset metadata for ingestion by OSTI
3 stars 1 forks source link

Simplify, update docstrings, and PEP8 - Scraper.py #42

Closed astrochun closed 2 years ago

astrochun commented 2 years ago

Closes #39 (see issue for description of suggested changes)

bess commented 2 years ago

@astrochun Welcome to Princeton! Looks like previously DRDS folks (the team I'm on) were reviewing PRs here. However, Kevin is no longer on our team. Are you hoping someone on our team will review this? Maybe we should talk about process? Looking forward to working with you!

astrochun commented 2 years ago

@astrochun Welcome to Princeton! Looks like previously DRDS folks (the team I'm on) were reviewing PRs here. However, Kevin is no longer on our team. Are you hoping someone on our team will review this? Maybe we should talk about process? Looking forward to working with you!

Yes, let's speak about process as I would like to follow whatever workflows and best practices your team have. This PR as well as other issues that I created were in part to understand dspace-osti as we are preparing for end of fiscal year submission. Wasn't sure who is best equipped to review this PR.

astrochun commented 2 years ago

We're using #47, so I'll closed this.