search

pulibrary / figgy

Valkyrie-based digital repository backend.
Other
36 stars 4 forks source link

Blue Button does not come up for CDL item(s) in Orangelight #6418

Closed kelea99 closed 3 months ago

kelea99 commented 4 months ago

Summary

Item: https://catalog.princeton.edu/catalog/9961193933506421

A student trying to access a CDL item from abroad is unable to do so. They are logged into VPN. Also tried an incognito window. We sent a demo to try to troubleshoot and they replied (see below):

So what happens on my end is that the “Princeton user log in” part does not come up. The slightly greyish field where the button appears loads but the button doesn’t. That’s where I get stuck.”

Impact

Please include hard deadlines, if the exhibit is part of an event, the issue is stopping work, etc.

Priority recommendation

Sudden Priority Justification

Required if "asap" or "within the next 3 weeks" is checked. Add "Sudden Priority" and "Maintenance/Research" labels If the blue button is not coming up or if redirects letting folks know items are checked out is broken, users cannot access our CDL items. This stops work.

Expected behaviour

Trying in private windows in Chrome, Firefox, and Safari. I click the log in button within the item record of my CDL item, it takes me to CAS, i give my princeton creds, I get my duo prompt on my phone, accept it and then it opens the viewer. I can view everything. I am not on the VPN. see demo below

Actual behaviour for external user:

So what happens on my end is that the “Princeton user log in” part does not come up. The slightly greyish field where the button appears loads but the button doesn’t. That’s where I get stuck.

Steps to reproduce behaviour

Screenshots / demos

https://github.com/pulibrary/figgy/assets/45043014/fed3ba0b-4d3b-4f36-9a53-9847e06efdff

Reproduction Steps

  1. Remove yourself as an admin from Figgy
  2. Go to https://catalog.princeton.edu/catalog/9961193933506421
  3. Log in
  4. Enjoy the gray window (it should be a "Check Out" button with a bunch of text)

First Step

Get the eligible item IDs from the figgy console, to ensure it's in CDL.

EligibleItemService.item_ids or something like that - if it returns an empty array, then it's not in CDL and it's a metadata problem.

If it returns item IDs, then we gotta figure it out.

Debugging Tips

Reproduce it and check the network tab to see what's being returned.

tpendragon commented 3 months ago

irb(main):001:0> CDL::EligibleItemService.item_ids(source_metadata_identifier: "9961193933 506421") => ["23554569550006421"]