search

pulibrary / firestone_locator

Location Mapper for Firestone Library
2 stars 1 forks source link

Items at the circulation desk #26

Closed carolyncole closed 4 years ago

carolyncole commented 5 years ago

The old site used to say ask for help on this item: https://library.princeton.edu/locator/index.php?loc=resc&id=943304&embed=true Screen Shot 2019-10-15 at 2 47 32 PM

The new site is now showing a map: https://libwebprod/locator/index.php?loc=resc&id=943304&embed=true Screen Shot 2019-10-15 at 2 47 48 PM

According to the new snap ticket they want to show a map to circulation: https://princeton.service-now.com/nav_to.do?uri=incident.do?sys_id=7f3be905dba404d4a341de82ca96190f

carolyncole commented 5 years ago

Here is another one that is not working: https://catalog.princeton.edu/catalog?utf8=✓&search_field=all_fields&q=Evicted+%3A+poverty+and+profit+in+the+American+city

https://catalog.princeton.edu/catalog/10926564

kevinreiss commented 5 years ago

This may be data problem. This view doesn't work, https://bibdata.princeton.edu/bibliographic/10926564/items.

carolyncole commented 5 years ago

That could be part of the problem, but this one does have items: https://bibdata.princeton.edu/bibliographic/9573790/items

I'll take a look at it tomorrow.

carolyncole commented 5 years ago

Here are two more issues: https://library.princeton.edu/locator/index.php?loc=resc&id=4830941&embed=true & https://locator-prod.princeton.edu/index.php?loc=resc&id=6095425&embed=true

kevinreiss commented 5 years ago

This is looking good from my perspective. Okay to close?

carolyncole commented 5 years ago

@kevinreiss I have one more PR, given the two additional issues I logged.
I added some tests and rewrote some of the code.