search

pulibrary / firestone_locator

Location Mapper for Firestone Library
2 stars 1 forks source link

Updating to use the locations from the catalog #30

Closed carolyncole closed 5 years ago

carolyncole commented 5 years ago

Also moved the code around a bit to allow for testing Added lando command to run phpunit tests

refs #26 (fixes the last two urls mention within the ticket).

The main changes to the code occur in bibdata_info.php. In there we check the location to see if it is set to something other than 'f' -> firestone. If it is set to something else we just put that in as a temporary location in the main record and do not bother getting the item level data from bibdata.

If 'f' is set as the location then we reach out to bibdata for the items, and follow the normal data gathering.

The rest of the changes are moving code into classes to make it easier to test.

carolyncole commented 5 years ago

@kevinreiss If you get a chance to review this PR. It addresses the additional two URLs that were found that did not work. I had a discussion with @tampakis this morning and he confirmed that we should be able to use the location passed to us by the Catalog.