LC Call Slips: Investigate behavior for Donatiello configuration - Githubissues

pulibrary / lib_jobs

Enterprise Services batch processing tasks. Rails 7 Ruby 3.1.0

3 stars 0 forks source link

LC Call Slips: Investigate behavior for Donatiello configuration #775

Closed maxkadel closed 1 month ago

maxkadel commented 2 months ago

Expected behavior

Each selector expects to get at least a couple records each week

Actual behavior

After a recent update to her configuration, Joann has found that she is not getting any records.

I have noticed that since I asked you to remove the economic subject headings I have not had any slips. It could definitely be that there just aren’t any but I am letting you know in case there is some other reason.

Steps to replicate

Not sure yet. Will update this issue.

Implementation notes, if any

May want to split out configs into separate files to read them more easily, and send them to stakeholders more easily
Test to somehow validate production configuration, without making it so that other tests change each time a config changes

maxkadel commented 1 month ago

Followed up with Joann via email.

In creating examples on staging, I do not see any records in the "all-relevant" spreadsheet that I would expect to be in Joann's spreadsheet based on her configuration.

Also created a separate test that loads the production config, just so we can ensure that it is valid without having it change all of our tests each time a selector wants a change in configuration.