Fixes Issue 56 - Githubissues

pulibrary / locations

Services around holding, delivery, and physical locations

MIT License

3 stars 0 forks source link

Fixes Issue 56 #63

Closed sdellis closed 8 years ago

sdellis commented 8 years ago

Still having trouble with the Floor controller tests due to path conventions that the tests don't seem to be aware of, but features work as expected.

coveralls commented 8 years ago

Coverage decreased (-5.9%) to 94.118% when pulling b1968dab377a5188cbd50b4ace95e1e67f9ea64f on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

kevinreiss commented 8 years ago

@sdellis Could you add a test for the validation flagged here, that will help raise the coveralls percentage, https://coveralls.io/builds/7092271/source?filename=app%2Fmodels%2Flocations%2Flibrary.rb. Could you also rebase this into a single commit? Please also address #64 in that commit too. Thanks.

coveralls commented 8 years ago

Coverage decreased (-4.8%) to 95.221% when pulling cdd764d273c6bf25be631c66eda5d25e6c63d03d on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage decreased (-3.3%) to 96.691% when pulling 0371a778d72acd7ae71673aa3ebb58fa07f218b1 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage decreased (-2.6%) to 97.426% when pulling 300f2839dbf2e9c0495fa1135b61be407802b355 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 99.634% when pulling 83a608dc19af447e3ca298374bbadb6f70a774a5 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 99.634% when pulling 077c1f7bdf1d4d6c49cad28ec7e63eae7176d7e5 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

kevinreiss commented 8 years ago

Could you add a test to address this coveralls flag? https://coveralls.io/builds/7125504/source?filename=app%2Fmodels%2Flocations%2Flibrary.rb

sdellis commented 8 years ago

Hmm, yeah, looking into it...

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 99.634% when pulling 6f9148c092b89510f31f202206bcfcd697a74eec on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 3d85b966b52c04b8715dac837011d775543ea7f4 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 102214defa0d3ed8af33dd03f8c27318dd281fe7 on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling 927ef7bdc1db49a870d57a7b6891e85257af442f on issue-56 into ee5c0920b6b8f0fc5a93c389dcca8e73ead3d416 on development.