search

pulibrary / orangelight

PUL Blacklight Project (Ruby 3.1.0, Rails 7.1.4)
21 stars 7 forks source link

Table of contents appear in the online label in the search results #2632

Closed christinach closed 9 months ago

christinach commented 3 years ago

Is it also counted in the online facet? Do we want to show this in the online label in the search results?

https://catalog.princeton.edu/catalog/99122674443506421 https://catalog.princeton.edu/catalog/99121162503506421 https://catalog.princeton.edu/catalog/99122539623506421 https://catalog.princeton.edu/catalog/99122676453506421 @mzelesky

christinach commented 3 years ago

I'm looking into this. Table of contents should not appear in the search results page.

christinach commented 3 years ago

We found with @mzelesky that there are records where the second indicator of the 856 indicated it was a full-text version of the resource, but there is a subfield 3 on the URL. @mzelesky will do a search over the Voyager records he submitted in the 'Print to Electronic' migration process and find how many have 856 with the subfield 3. I will look if I can search 856s with subfields using analytics in alma.

christinach commented 3 years ago

Some of these records will clean up during a data cleanup of 856s https://github.com/pulibrary/bibdata/issues/1600

kevinreiss commented 2 years ago

Clean-up is still in progress.

kevinreiss commented 9 months ago

Some of the examples are still exhibiting the behavior. Fundamentally this is a clean-up ticket. @mzelesky can I close this one in favor of any alma-config tickets related to 856 clean-up?

mzelesky commented 9 months ago

99121162503506421 is an ark, which is the only one I see.

mzelesky commented 9 months ago

All URLs that are a Princeton domain were not touched. Also, cataloging managers explained that they will continue to add tables of contents when they feel it is appropriate.

Does this mean a new use case?

kevinreiss commented 9 months ago

If the TOC is properly cataloged our code will not include in the online facet as things stand now: https://github.com/pulibrary/bibdata/blob/5e57a4488e470deeea1f539a9a87473fb8c90f9c/marc_to_solr/lib/access_facet_builder.rb#L46. @mzelesky perhaps we can actually just close this one. I don't think there is a new use case.

mzelesky commented 9 months ago

Ok, we will communicate the importance of correct indicators for tables of contents URLs.