pulibrary / orangelight

PUL Blacklight Project (Ruby 3.1.0, Rails 7.1.4)
21 stars 7 forks source link

How should algorithm switching be implemented such that it goes into the code base? #3749

Closed tpendragon closed 11 months ago

tpendragon commented 1 year ago

Part of #3744

We don't want to actually implement a secondary algorithm, so where can we get this code in such that it's a maintenance burden we're comfortable with? We don't want a long running branch from this work.

Options:

We're especially looking for feedback from DACS on this.

Acceptance Criteria

Communicate with DACS and get confirmation that if we add a feature flipper that we can merge our PRs into main and they're okay with that maintenance burden.

hackartisan commented 11 months ago

I think the feature flipper is the best way forward. It is an accepted and well-understood pattern on the DACS team, and this feature is new enough that we're not even sure we're going to commit fully to it, so it seems premature to ask the Blacklight community to take on its maintenance.

carolyncole commented 11 months ago

Documentation PRs can be merged outside a feature flipper Code PRs need to be behind a feature flipper