pulibrary / pdc_discovery

Princeton Data Commons discovery portal for Research Data
10 stars 0 forks source link

Facet sorting by year and author not working #572

Closed astrochun closed 5 months ago

astrochun commented 5 months ago

Recently tried to sort the PPPL results of datasets in Discovery by year and authorship and the results were inconsistent with expectations.

See screenshots:

By year: Screen Shot 2024-02-27 at 7 26 25 AM

By author: Screen Shot 2024-02-27 at 7 26 44 AM

Might be related to the home page show. These items show both describe and dataspace. PPPL content has been migrated, so we may not to worry about the dpsace content

Acceptance criteria:

carolyncole commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @bess @JaymeeH @jrgriffiniii @leefaisonr @hectorcorrea

carolyncole commented 5 months ago

@astrochun The way the current Author sort is working is that the authors of the paper are sorted in alphabetical order and then the one earliest in the alphabet is utilized. So for a paper that has "Smith,Jane" as the first author and "Doe, John" as the second author, because Doe is earlier in the alphabet it is utilized for sorting. I would assume that we should really just be sorting by the first author?

astrochun commented 5 months ago

@astrochun The way the current Author sort is working is that the authors of the paper are sorted in alphabetical order and then the one earliest in the alphabet is utilized. So for a paper that has "Smith,Jane" as the first author and "Doe, John" as the second author, because Doe is earlier in the alphabet it is utilized for sorting. I would assume that we should really just be sorting by the first author?

Understood so then why is the example I provided shows Mollen before Gan? There should be some with last name starting in A's.