pulibrary / pdc_discovery

Princeton Data Commons discovery portal for Research Data
10 stars 0 forks source link

Error handling when indexing DataSpace datasets #622

Closed hectorcorrea closed 2 months ago

hectorcorrea commented 2 months ago

This PR undoes a commit that I did as part of this PR: https://github.com/pulibrary/pdc_discovery/pull/620/files

Catching the DataSpace exception has the unintended consequence of continuing the indexing process (which sounds like a good idea) but that results in a new index with no DataSpace records.

In this PR I am letting the exception flow (as it did before) which stops the indexing process and keeps the previous data in place. Not ideal but all in all a better outcome than blowing away the DataSpace records every time DataSpace is not available during the reindex process, which sadly is quite common.