search

pulibrary / pdc_discovery

Princeton Data Commons discovery portal for Research Data
10 stars 0 forks source link

Repairing code coverage reporting and enabling SimpleCov HTML report generation #657

Closed jrgriffiniii closed 1 month ago

jrgriffiniii commented 1 month ago

This was discovered while @20LM22 was advancing #650.

jrgriffiniii commented 1 month ago

https://github.com/pulibrary/pdc_discovery/pull/657/commits/7451cee89eb1be4522721c8ec0d5127ed2656ff3 was the most concerning aspect of this PR to me. ~If removing these filters does not significantly lower the test coverage, then I would prefer to have these removed please.~ The test coverage was not adversely affected by removing these lines.

jrgriffiniii commented 1 month ago

96.41% coverage is being reported by this: https://output.circle-artifacts.com/output/job/6dc4ff03-ed51-42f9-878e-37fc5b01b399/artifacts/0/~/pdc_discovery/coverage/index.html#_AllFiles