pulibrary / pdc_discovery

Princeton Data Commons discovery portal for Research Data
10 stars 0 forks source link

I650 20lm22 advance code coverage #661

Closed 20LM22 closed 1 month ago

20LM22 commented 1 month ago

Increases code testing coverage to 97.79%, includes notes where testing coverage is not possible/does not make sense

jrgriffiniii commented 1 month ago

Regarding the failing circleci tests, I am finding the following locally for the Solr Docker container:

$ curl http://localhost:57932/solr/pdc-core-test/select
{
  "responseHeader":{
    "status":0,
    "QTime":6,
    "params":{}},
  "response":{"numFound":67,"start":0,"maxScore":1.0,"docs":[
      {                                                                                                                                                         "id":"doi-10-34770-k547-cq20",
        "data_source_ssi":"pdc_describe",

but on CircleCI, I am finding the following:

$ curl http://[...]@localhost:8983/solr/pdc-core-test/select
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 404 Not Found</title>
</head>
<body><h2>HTTP ERROR 404</h2>
<p>Problem accessing /solr/pdc-core-test/select. Reason:
<pre>    Not Found</pre></p>
</body>
</html>