search

pulibrary / pul_library_drupal

Deprecated - Princeton University Library Core Site Drupal Codebase
https://library.princeton.edu/
GNU General Public License v2.0
3 stars 0 forks source link

Remove references to pul_resolver/proxy base #1972

Closed kevinreiss closed 1 year ago

kevinreiss commented 1 year ago

Remove references to the pul_resolver (aka the shim) that reside in various javascript files in the project.

https://github.com/pulibrary/pul_library_drupal/search?q=resolve%2Flookup

deploy in conjunction with https://github.com/pulibrary/discoveryutils/issues/222. issue closed

Implementation Notes

This will involve re-compiling the theme with gulp so there is chance that may have some issues as it some time since we've done that.

kevinreiss commented 1 year ago

Waiting for OK from ERM team that we can do this. Hope on 4/12 to confirm these can go.

kevinreiss commented 1 year ago

ERM team asked to check back in one more week.

kevinreiss commented 1 year ago

We can move forward with this when we have chance.