search

pulibrary / pul_metadata_services

PUL Metadata Services
Apache License 2.0
1 stars 1 forks source link

Handing missing box/folder info #14

Closed escowles closed 7 years ago

escowles commented 7 years ago

Switching to a real metadata file and handling missing box/folder info it demonstrates.

jpstroop commented 7 years ago

Do you have a sample component from the PULFA site where this info is missing? I'm wondering if it's related to a change in how Manuscripts handles holding data in their EADs.

escowles commented 7 years ago

Yes, these changes were because the records I was working with sometimes has a box number but no folder, or vice versa. E.g.: http://findingaids.princeton.edu/collections/AC057/c18.xml and http://findingaids.princeton.edu/collections/RBD1/c9626.xml

jpstroop commented 7 years ago

Oh, I see. It wasn't missing entirely, just wasn't always box and folder?

http://findingaids.princeton.edu/collections/RBD1/c9626.xml?scope=record

escowles commented 7 years ago

Right — the records I was testing with initially all had box and folder — this update was mostly to handle one or the other missing. For good measure, it also works if both are missing.

jpstroop commented 7 years ago

👍