pulibrary / static-tables

Searchable index of Marquand Auction Catalogs
https://library.princeton.edu/marquand_catalogs/
MIT License
0 stars 0 forks source link

Banner image should have configurable alt attribute #137

Open maxkadel opened 3 months ago

maxkadel commented 3 months ago

Steps to recreate

  1. Add a new Banner image for another page, e.g. Undergrad Alumni Index, using the configuration.
  2. Note that the alt text for the image, no matter what it is, is "geometric pattern"

Issues

Images should have meaningful alt text that reflect the image

Severity

WCAG Success Criterion

WCAG Conformance level (A, AA, AAA)

User impact

Misleads a user using assistive technology about the display of the page, loses any meaning conveyed by the image, such as a sense of place.

Recommended fix

Add alt text for banner image to the configuration

Acceptance criteria

Notes

kevinreiss commented 3 months ago

I believe we've closed this issue in this commit: https://github.com/pulibrary/static-tables/commit/dd4e5fc787aa4670be991ad0bdf087a5cf2602a0.

maxkadel commented 3 months ago

In the linked commit the alt text for the banner image is still alt="geometric pattern"

kevinreiss commented 3 months ago

Does having at least some text (even if it's boilerplate) meet the accessibility requirement?

maxkadel commented 3 months ago

I don't think so? I think if the image adds meaning to the page it needs meaningful alt text, and if it does not add meaning to the page it should be hidden from screen readers.

christinach commented 3 months ago

The allt attribute should describe the image. If the image is not a geometric pattern it shouldn't be geometric pattern. I agree that we should try to configure it in a config file for all the sites.