pulibrary / tiger-data-app

TigerData is a comprehensive set of data storage and management tools and services that provides storage capacity, reliability, functionality, and performance to meet the needs of a rapidly changing research landscape and to enable new opportunities for leveraging the power of institutional data.
Apache License 2.0
6 stars 0 forks source link

rspec ./spec/models/mediaflux/http/asset_exist_request_spec.rb:15 is failing oftent in CI #828

Closed carolyncole closed 4 days ago

carolyncole commented 2 weeks ago

What maintenance needs to be done?

We should take time to figure out why it is so flaky

It looks like there is more than one flaky test, we just noted that collection_asset_root_request also is failing intermittently.

Level of urgency

Why is this maintenance needed?

This is slowing down PRs

Acceptance criteria

hectorcorrea commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @carolyncole @JaymeeH @jrgriffiniii @kelynch @leefaisonr

carolyncole commented 1 week ago

All the following went green after a rerun from failed: rspec ./spec/models/mediaflux/project_update_request_spec.rb:57 rspec ./spec/models/mediaflux/http/asset_exist_request_spec.rb:15 rspec ./spec/models/mediaflux/http/collection_asset_create_root_request_spec.rb:9

bess commented 1 week ago

Documenting more flakiness: Screenshot 2024-07-18 at 1 15 09 PM

carolyncole commented 1 week ago

https://app.circleci.com/insights/github/pulibrary/tiger-data-app/workflows/build_accept_deploy/tests?branch=main contains all flaky test runs as defined by CI in the flaky section

hectorcorrea commented 1 week ago

@carolyncole this is great information, I didn't know CircleCI kept track of flaky tests.

PR #843 (merged a couple of hours ago) should take care of Mediaflux::Http::CollectionAssetCreateRootRequest -- if that works we can probably try to apply a similar approach to the rest.

carolyncole commented 1 week ago

@hectorcorrea The root namespace is cleared out before each test. You can see in a couple of the flaky tests that the namespace not existing is the reason for the failure. I'm guessing that there is some sort of error during the deletion creation https://github.com/pulibrary/tiger-data-app/blob/main/spec/support/connect_to_mediaflux.rb#L16-L24