pulilab / vue-people

VuePeople lists and connects Vue.JS developers around the world.
https://vuepeople.org
MIT License
172 stars 36 forks source link

Speed improvement: One single tooltip shared among all user-markers #117

Closed DonNicoJs closed 5 years ago

DonNicoJs commented 5 years ago

Currently the each MapMaarker instantiate a l-tooltip inside. This is suboptimal since we always show only one tooltip at a time.

What is needed is to remove the l-tooltip from every marker, add one l-layer-group inside the l-map with inside a 'general tooltip' and display that tooltip on marker over on the correct coordinates.

This will reduce the amount of drawn element in the dom and speed up the page / responsiveness of the map.

This needs to be done only for people markers / tooltip and not for meetup ones.

flurmbo commented 5 years ago

I'd like to try this one if that's okay!

DonNicoJs commented 5 years ago

@flurmbo go on without worries! Let me know if you need anything

flurmbo commented 5 years ago

Hey @lordfuoco, I'm having some issues setting up a development environment. A lot seems to be going wrong, so I'll just summarize some of the errors!

I copied the dummy certs to the nginx/certs folder and otherwise tried following the instructions in the readme. I am using Windows 7.

Any help getting this to run would be greatly appreciated[ the Vue code looks really cool. I am completely new to nuxt, docker and SSL certificates, so maybe I'm missing something obvious!

DonNicoJs commented 5 years ago

Hi @flurmbo this is a tipical error that occurs when the frontend dev server proxy can't reach the backend.

Please verify that your docker is running by going to your browser at: localhost and localhost/admin

Docker logs can be accessed by the command: docker-compose logs run in the project root folder

Did you run the migrations?

Also now I am on the go but when I reach the office I will update the how to contribute guide on how to config and access the admin console (so that one can login with GitHub and create a pin) and maybe add a dummy db with few pins

DonNicoJs commented 5 years ago

@flurmbo I have updated the contribution guide, you may want to take a look :)

flurmbo commented 5 years ago

@lordfuoco Thanks for the help, unfortunately I'm still having trouble. If I run "docker ps" all the containers seem to be running, but when I point my browser to localhost/admin I get a 404. I ran the migrations and it says "no migrations to apply", I've also made a superuser. Is there anything I need to change in django/.env other than setting DEBUG to True?

DonNicoJs commented 5 years ago

@flurmbo this make me think that ngninx container has a problem / is not correctly running.

Try to check with docker-compose logs nginx Sorry for the messy dev experience, I will update the readme once again with the debug=true

Here is late so I will be able to answer only tomorrow but write with any update

flurmbo commented 5 years ago

No problem, it's been fun trying out docker. If the problem is with nginx, then this warning might have something to do with it:

nginx_1 [warn] 1#1: "ssl_stapling ignored, no OCSP responder URL in the certificate "/etc/letsencrypt/cert.pem"

DonNicoJs commented 5 years ago

@flurmbo the ssl stapling is not a problem :) can you just be sure that you rebooted doocker after adding Debug=True ? this is my django/.env

SECRET_KEY= 'somevalue'
SENTRY_DSN=
DEBUG=True
DATABASE_URL=postgis
MEETUP_API_KEY=
DonNicoJs commented 5 years ago

I am taking this

DonNicoJs commented 5 years ago

@flurmbo if you are interested the PR contains the full fix for this!

Thank you anyhow for trying!

flurmbo commented 5 years ago

Thanks! Looks good