Ui Improvement: Collect user discord tag

pulilab / vue-people

VuePeople lists and connects Vue.JS developers around the world.

https://vuepeople.org

MIT License

172 stars 36 forks source link

Closed JoelLau closed 5 years ago

JoelLau commented 5 years ago

Attempt to resolve Issue #120

Modifycomponents/UserProfileForm.vue to collect the discordTag, right after the twitter profile
Modify components/PersonDetails.vue to display the discord icon (and link to discord profile ) after twitter icon on the top
Modify django/people/models.py to include discordTag as a field
Verify that everything works is and properly wired.

DonNicoJs commented 5 years ago

@JoelLau Hi thank you for your PR!

Three things:

discord_tag is a simple string not an url, sorry maybe you were mislead by the twitter and github ones
Please create the migrations with docker-compose exec django python manage.py makemigrations ( after having adjusted the discord_tag name and type) and commit them
( this is my mistake) since it's a tag and not an url it should not be near twitter or github in components/PersonDetails.vue but as another section under Organisation.

JoelLau commented 5 years ago

noted, I'm having some trouble with docker at the moment. gotta reinstall

DonNicoJs commented 5 years ago

@JoelLau I have updated the contribution guide, you may want to take a look :)

JoelLau commented 5 years ago

urgh. having problems with docker on my windows machine ):

hope you don't mind me taking a few more hours to finish this

DonNicoJs commented 5 years ago

@JoelLau no pressure! Quality over quantity :)

DonNicoJs commented 5 years ago

@JoelLau do you plan to finish this pr ?

JoelLau commented 5 years ago

sorry, I couldn't get it to work ):