pulilab / vue-qr-reader

Vue component to scan QR codes
https://pulilab.github.io/vue-qr-reader/#/
MIT License
49 stars 13 forks source link

Rename component class name 'container' #20

Closed fernandoagarcia closed 5 years ago

fernandoagarcia commented 5 years ago

Renamed container so not to clash with other broad container class names

kielabokkie commented 5 years ago

Hi @DonNicoJs, is it possible to release a new minor version that includes this change? Including this component in my project currently messes up the layout.

DonNicoJs commented 5 years ago

@kielabokkie I will release a minor this week :) thanks for the ping

kielabokkie commented 5 years ago

@DonNicoJs Nice one, cheers!

By the way, the issue was caused because the scoping of the css was incorrect. It currently says <style scope> instead of <style scoped>. Renaming the class to be more specific works too though 😄

DonNicoJs commented 5 years ago

@kielabokkie Released!

kielabokkie commented 5 years ago

@DonNicoJs Thanks 😄