Add optional timeout arguments to `cellular` and `gps` functions

pulkin / micropython

MicroPython implementation on Ai-Thinker GPRS module A9 (RDA8955)

https://micropython.org

MIT License

103 stars 30 forks source link

Add optional timeout arguments to `cellular` and `gps` functions #67

Closed bokolob closed 3 years ago

pulkin commented 3 years ago

I see some valuable additions, thank you. I'll need more time to merge everything. Btw, there is an abandoned sms_from_raw which might be of your interest.

bokolob commented 3 years ago

My fix for SMS.list() is broken 8(

bokolob commented 3 years ago

By now everything is ok :)

pulkin commented 3 years ago

I added cellular.SMS(timeout) and cellular.SMS.get_storage_size() based on what is here. I also added the atomic section macro but I am wondering if there is any practical matter why you defined it?

I did not touch the rest yet. It would be much better if you make small PRs addressing specific points.

bokolob commented 3 years ago

About atomic section. I’m planning to add interrups support, and then e.g. schedule method might be called inside himself. By now I can’t say for sure, but it makes code seems more reliable for different kind of usages.