pulkithanda / voyager-hf

Voyager website: A space website that can be used as a template in the future for space-related topics.
https://voyager-website.herokuapp.com/
41 stars 44 forks source link

added search button #55

Closed JanviRaina closed 2 years ago

JanviRaina commented 2 years ago

Hey can you review my PR.

pulkithanda commented 2 years ago

Hey @JanviRaina, Sorry but give sometime please (exams) will definitely view it tomorrow

pulkithanda commented 2 years ago

Hey @JanviRaina please resolve the merge conflicts

JanviRaina commented 2 years ago

Hey @JanviRaina, Sorry but give sometime please (exams) will definitely view it tomorrow

No problem at all.

pulkithanda commented 2 years ago

Hey, @JanviRaina I cloned your repository to see the changes but didn't find any !? Can you check once if your forked repository has all the changes?

JanviRaina commented 2 years ago

Hey, @JanviRaina I cloned your repository to see the changes but didn't find any !? Can you check once if your forked repository has all the changes?

I can see the changes in 'janvir' branch

pulkithanda commented 2 years ago

Hmm, I'm facing an error while cloning cant see them, instead of branching can you directly push them to your forked repos main branch?

gamer-1478 commented 2 years ago

I would also suggest you should place all the css in the main.css and not use styles tag as to be inline with the current project structure.

JanviRaina commented 2 years ago

Yes I will try to fix this. Thank You.

pulkithanda commented 2 years ago

@JanviRaina Do you want to work further or do i mark it as hacktoberfest-accepted if you aren't able to ?

JanviRaina commented 2 years ago

@JanviRaina Do you want to work further or do i mark it as hacktoberfest-accepted if you aren't able to ?

You can mark it as hacktoberfest-accepted.

pulkithanda commented 2 years ago

Ok @JanviRaina Sure great work. Thank you for contributing ^_^.

pulkithanda commented 2 years ago

Do tell me if you have any problems, it should show on your hf profile in sometime.