pulkitjalan / google-apiclient

Google api php client wrapper with Cloud Platform and Laravel support
MIT License
246 stars 75 forks source link

Laravel 9.x Compatibility #58

Closed laravel-shift closed 2 years ago

laravel-shift commented 2 years ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 2 years ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift commented 2 years ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/google-apiclient.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "pulkitjalan/google-apiclient": "dev-l9-compatibility",
    }
}

Finally, run: composer update

mralston commented 2 years ago

The package seems to work in my testing once the dependency has been updated. Upvote this PR 👍

wardhache commented 2 years ago

@pulkitjalan Would it be possible to review and possibly merge this Pull Request? We would love to update our project to Laravel 9!

fregoe commented 2 years ago

@pulkitjalan Please review and merge this pull request. I want also update my projects to Laravel 9.

Lavaei commented 2 years ago

I wonder why this simple pull request is still open without any review. It breaks many packages and prevents many projects from upgrading to the latest version of Laravel.

jason-nabooki commented 2 years ago

Anyone using the https://github.com/laravel-shift/google-apiclient.git repo be very careful...it's not the latest version of the package.

So you may be downgrading which will cause issues if you refactored to use the new Google Service class names.

Nuvm commented 2 years ago

@pulkitjalan Please review and merge this to enable Laravel 9 projects. Thanks!