pull-stream / stream-to-pull-stream

convert a node stream (classic or new) into a pull-stream
MIT License
30 stars 5 forks source link

Promise support #13

Closed tjconcept closed 6 years ago

tjconcept commented 6 years ago
  1. What do you think of adding support for promises in this library, such that a sink returns a promise if no callback is supplied?
  2. Would you accept a PR implementing it?

My rough idea for an implementation is along the lines of:

let p
if (!cb) {
  p = new Promise((resolve, reject) => {
    cb = err => err ? reject(err) : resolve()
  })
}

[existing code]

return p
dominictarr commented 6 years ago

not interested. if you want promises, make a wrapper module.