search

pullingshots / Shipment

Perl interface into various shipping web service API's - FedEx, UPS, Purolator, Temando, Canada Post
https://metacpan.org/pod/Shipment
19 stars 19 forks source link

printer_type isa Str but should be PrinterOptions? #33

Closed SysPete closed 8 years ago

SysPete commented 9 years ago

enum PrinterOptions is defined in Shipment::Base and also overridden in Shipment::UPS but the type for printer_type attribute is 'Str'. I guess either the enum definitions should be removed or printer_type isa should be corrected.

pullingshots commented 8 years ago

The enum definitions have been removed from the Base class.

It is up to the extended classes to enforce type constraints on this.