search

pullreminders / backlog

Public backlog for http://pullpanda.com
59 stars 9 forks source link

As a user, I would like to be able to ignore a specific pattern of a pull request title from being assigned to reviewers #138

Closed maxgutman closed 5 years ago

maxgutman commented 5 years ago

The use-case for us is we automatically generate PRs that contain multiple already reviewed commits as part of our release workflow. Additionally, we sometimes create PRs that we want to have a peer review before opening it up to others and we usually label those with something like [DO NOT REVIEW]

abinoda commented 5 years ago

@maxgutman Is this request for Pull Assigner or reminders?

maxgutman commented 5 years ago

Pull Assigner!

abinoda commented 5 years ago

@maxgutman Gotcha. Still would like to understand better – is the issue that you're using CODEOWNERS so Pull Assigner automatically gets triggered on all PRs? And so you'd like a way to tell Pull Assigner to not run on certain PRs?

maxgutman commented 5 years ago

Yes, exactly, we're using CODEOWNERS to automate every PR

On Thu, Feb 28, 2019, 4:39 PM Abi Noda notifications@github.com wrote:

@maxgutman https://github.com/maxgutman Gotcha. Still would like to understand better – is the issue that you're using CODEOWNERS so Pull Assigner automatically gets triggered on all PRs? And so you'd like a way to tell Pull Assigner to not run on certain PRs?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/138#issuecomment-468496661, or mute the thread https://github.com/notifications/unsubscribe-auth/AArtOG5UPxq8HgJHaqrY0Qt6hZYSBiD3ks5vSHbMgaJpZM4bXhrs .

abinoda commented 5 years ago

@maxgutman Got it, will get to this soon. Would disabling based on label work or does it have to be title substring?

maxgutman commented 5 years ago

Label would work too

On Sun, Mar 3, 2019, 6:39 PM Abi Noda notifications@github.com wrote:

@maxgutman https://github.com/maxgutman Got it, will get to this soon. Would disabling based on label work or does it have to be title substring?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/138#issuecomment-469098592, or mute the thread https://github.com/notifications/unsubscribe-auth/AArtOGPvh9VxVGnu7AZEtrLtdLSFF38kks5vTIdJgaJpZM4bXhrs .

abinoda commented 5 years ago

@maxgutman Working on this now. Would it be OK if for now we hardcoded a stop-word label on our end, for example a label named disable-pullassigner. Down the road we could let you choose your own labels but it'd be simpler for now if we chose some hard-set default like this.

maxgutman commented 5 years ago

Sure, that works for us for now.

On Fri, Mar 8, 2019, 9:57 AM Abi Noda notifications@github.com wrote:

@maxgutman https://github.com/maxgutman Working on this now. Would it be OK if for now we hardcoded a stop-word label on our end, for example a label named disable-pullassigner. Down the road we could let you choose your own labels but it'd be simpler for now if we chose some hard-set default like this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/138#issuecomment-471018575, or mute the thread https://github.com/notifications/unsubscribe-auth/AArtOKb_XGIBmwqHDXLkgOF-usvbeQ4Zks5vUqR_gaJpZM4bXhrs .

abinoda commented 5 years ago

@maxgutman This is live. Just use the label pullassigner-ignored (case insensitive) on any pull request where you do not want Pull Assigner to run. Let me know if you run into any issues!

abinoda commented 5 years ago

@maxgutman Please let me know if this resolved your problem!

maxgutman commented 5 years ago

Yes it has. Thanks

On Wed, Mar 13, 2019, 10:02 AM Abi Noda notifications@github.com wrote:

@maxgutman https://github.com/maxgutman Please let me know if this resolved your problem!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pullreminders/backlog/issues/138#issuecomment-472514441, or mute the thread https://github.com/notifications/unsubscribe-auth/AArtOIei7obrf3vry5KCknV7JtnvaPexks5vWS8_gaJpZM4bXhrs .