search

pullreminders / backlog

Public backlog for http://pullpanda.com
59 stars 9 forks source link

Filter PRs by GitHub Team - restrict to Teams, not members of teams #176

Open fredden opened 5 years ago

fredden commented 5 years ago

Similarly to #170, we have a number of teams with partially overlapping memberships. This is causing us trouble when we want to Filter PRs by GitHub Team, as this filter seems to be "members of GitHub Teams" rather than "GitHub Teams" themselves. When requesting a review from a team, I would like this to show up in the associated room for that team, but not rooms for other teams (which have users in both).

For example, with the following team memberships:

When requesting a review from the Python team, this shows up in both the rooms for JavaScript and Python. The notification in the room for Python is expected and helpful; the notification in the room for JavaScript is not. This seems to be because Bob is in both teams. The JavaScript team does not need to be notified about this pull request, creating noise in that room.

Also, when requesting a review from Carol, this shows up in all three rooms since she is a member of all three teams.

sheldonhull commented 4 years ago

Is this what is powering the github feature for setting up pull request reminders? Is there a better place to go about that now?

I want to setup reminders for all repositories a team maintains rather than globally. With over 80 repos, doing this one by one on the reminder field is not maintainable. Any advice or pointer to where I should submit this type of request would be appreciated.