search

pullreminders / backlog

Public backlog for http://pullpanda.com
59 stars 9 forks source link

As a user, I would like to be notified when someone re-requests my review on a PR #182

Open jsjoeio opened 5 years ago

jsjoeio commented 5 years ago

Currently, our workflow looks like this:

  1. Developer submits Pull Request.
  2. Under "Reviewers", Developer requests entire team.
  3. A Team Member reviews the PR and requests changes.
  4. The Developer makes the changes and updates the PR.
  5. The Developer clicks "Re-request review"
  6. What we want to happen -> Pullreminder sends a message: a. directly to a #channel on Slack to the person whom the Developer is re-requesting a review.

This would be helpful because:

  1. most of us have too many GitHub notifications to check the bell on github.com
  2. most of us don't check our email frequent enough to rely on the email notification.

We would greatly appreciate it!

Thank you! 🙏

Requested on behalf of the Team at @echobind

abinoda commented 5 years ago

@jsjoeio The DMs for re-requested reviews should already work, right?

jsjoeio commented 5 years ago

@abinoda apologies - you're absolutely right. My teammate and I just tested and we can confirm it works:

  1. First it shows the team's review has been requested.
  2. Then when she clicked re-request for me specifically, I received a DM

image

I'll update my original comment