search

pullreminders / backlog

Public backlog for http://pullpanda.com
59 stars 9 forks source link

It it possible to restrict members from updating target values? #93

Open davidgoate opened 6 years ago

davidgoate commented 6 years ago

It would seem that any member can update PR targets like the target review turnaround time. Is it possible that only some users or just the "owner" can do that?

abinoda commented 6 years ago

@davidgoate Hi David, thanks for submitting this. On the fence about this one only because a lot of teams aren't super strict or methodical about who is an "owner" and who is a "member". What do you think?

davidgoate commented 6 years ago

@abinoda I can see both sides, we are quite a small team and I do trust that people wouldn't change the targets with malicious intent, but we are starting to take these metrics more and more seriously and it would be annoying if we did find the metrics looked good only to later discoverer the targets were relaxed some time ago without proper consultation about why.

As a side note, I've not taken to opportunity to say thanks for this application and tooling, we would be lost without it. The slack notifications and metrics on turnaround, throughput and merge time we find really 👍

abinoda commented 6 years ago

@davidgoate One thing to note – the target success rates are calculated on the fly. So even if someone changes the target, you can change it back and the current/historical target success rates will be based on the currently set target.

And thanks for the kind words!