pulp-platform / chimera

Other
9 stars 1 forks source link

Integrate Hyperbus peripheral #47

Closed sermazz closed 1 day ago

sermazz commented 1 month ago

This PR:

sermazz commented 2 weeks ago

@Lore0599 @arpansur @Scheremo @adimauro-iis CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for https://github.com/pulp-platform/chimera/issues/43. If these are not blocking, we can merge.

Scheremo commented 2 weeks ago

@Lore0599 @arpansur @Scheremo @adimauro-iis CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for #43. If these are not blocking, we can merge.

I think both are blocking but trivial to resolve. You can extend the register memory map range (0x3000_0000 - 0x4000_0000) contiguously with the config registers and map the hyperbus memory "somewhere reasonable" (why not 0x5000_0000?)

sermazz commented 4 days ago

Should be ready to merge.

You can check the last commits that I added. Let me know if there's any further feedback :)

Scheremo commented 4 days ago

Should be ready to merge.

  • I integrated Morit's fixes from b67f438 and further fixed some small stuff
  • Fixed the linting
  • Connected the hyperbus peripheral to the regbus by instantiating another external regbus port in Cheshire

You can check the last commits that I added. Let me know if there's any further feedback :)

Hey Sergio, thanks for the effort! All my comments are satisfied; we might want to add a few more large-scale tests, but the RTL looks mergeable to me.