search

pulp-platform / common_cells

Common SystemVerilog components
Other
488 stars 138 forks source link

Renamed `translate_off` to `` `ifndef SYNTHESIS `` #210

Closed sifferman closed 6 months ago

sifferman commented 7 months ago

Hello!

According to the IEEE 1364.1-2005 spec 6.3.2, the use of translate_off/translate_on is discouraged as opposed to `ifndef SYNTHESIS. Plus, some newer SystemVerilog frontends such as sv2v, Verible, and PySlint do not have any extra AST support for translate_off, so they may get confused by unsupported unsynthesizable constructs.

Therefore, I changed 38 occurrences of translate_off to `ifndef SYNTHESIS. However, I kept 4 deprecated modules with translate_off because I wasn't sure whether they should match the non-deprecated modules' style:

Also, I would be happy to hear another perspective if you feel that translate_off is in fact the better option.

Thanks!

sifferman commented 6 months ago

@niwis Thanks for the response, and good catch! I corrected stream_fifo_optimal_wrap.sv. I also added the changes for the deprecated modules.

I can squash if needed.

sifferman commented 6 months ago

Thanks!