pulp-platform / common_cells

Common SystemVerilog components
Other
488 stars 138 forks source link

‘steam_join_dynamic’ handshakes unselected streams #213

Open otoomey opened 6 months ago

otoomey commented 6 months ago

The ‘sel’ signal currently acts (inverted) like the ‘drop’ signal seen in the likes of ‘stream_filter’.

This may be intended behaviour but strikes me as somewhat unexpected. In my specific use case I have two streams. Based on a condition I am ready to accept the output of just one or both streams (so mux cannot be used here). The current behaviour of this module causes data from the stream I am not ready to accept to be thrown away.