ZynqAPBSPIIF::is_fpga_programmed looks at more bits than intended(?)

pulp-platform / debug_bridge

BSD 3-Clause "New" or "Revised" License

7 stars 9 forks source link

ZynqAPBSPIIF::is_fpga_programmed looks at more bits than intended(?) #13

Open stefanct opened 5 years ago

stefanct commented 5 years ago

https://github.com/pulp-platform/debug_bridge/blob/cce9e95e29b473932292d78bd3c223b556f79ce0/mem_zynq_apb_spi.cpp#L97

I think this statement is missing a & 0x1 at the end (and another set of parentheses around its left operand) - at least if it's trying to read IXR_PCFG_DONE only as I assume.