pulp-platform / hero-sdk

⛔ DEPRECATED ⛔ HERO Software Development Kit
https://www.pulp-platform.org/hero
Apache License 2.0
20 stars 6 forks source link

v1.0.2-rc1: bug fix #28. Fixed internal repo checkout. #29

Closed alessandrocapotondi closed 6 years ago

alessandrocapotondi commented 6 years ago

Bug fix #28

alessandrocapotondi commented 6 years ago

yes

vogelpi commented 6 years ago

Maybe, the same changes you made to scripts/hero/setup.sh should also be made to scripts/bigpulp/setup.sh. But without testing it on bigPULP it is maybe not a good idea. What do you thinkg @alessandrocapotondi @accuminium ?

andreaskurth commented 6 years ago

@vogelpi I think changing it in bigPULP without testing is fine in this case, since bigPULP is currently not supported (and unstable), and this change is anyway required to get it running.