search

pulp-platform / pulp_soc

pulp_soc is the core building component of PULP based SoCs
Other
78 stars 81 forks source link

Merge `update-hwpe` branch into `master` and then delete the branch? #48

Closed vogelpi closed 3 years ago

vogelpi commented 3 years ago

Hi @FrancescoConti , @micprog just noted that pulp lo longer references master but instead the the v.1.4.3 tag on the update-hwpe branch of pulp_soc. This looks bad and could lead to problems and merge madness in later PRs. I think it would be much better to merge the update-hwpe branch into master and then delete the branch. Or is there a particular reason why not merging it into master?

Also pinging the repo owner @bluewww .

FrancescoConti commented 3 years ago

Nope, simply a mistake with the missing merge.

vogelpi commented 3 years ago

Ah I see. Thanks for your feedback @FrancescoConti . What is your plan now? Do you want to merge update-hwpe into master? I think if it's properly done, the commit ID/tag should still remain the same.

FrancescoConti commented 3 years ago

Yes -- it's simply a version bump so there should be no particular issue. If necessary, we can also push the minor patch tag up one notch. See #49