search

pulp-platform / pulp_soc

pulp_soc is the core building component of PULP based SoCs
Other
78 stars 81 forks source link

Bump dependencies with `tech_cells_generic` compatibility #53

Closed micprog closed 3 years ago

micprog commented 3 years ago

This PR updates certain dependencies to reference newer versions of tech_cells_generic, such that no version conflicts persist across dependencies. This allows for bender to automatically resolve dependencies, without requiring an override or manual selection of a version, at least regarding tech_cells_generic.

This issue still persists for axi due to axi_slice_dc calling an older axi version. register_interface is updated here to avoid this issue.

bluewww commented 3 years ago

We need to make sure that we also bump ips_list.yml @meggiman

bluewww commented 3 years ago

register_interface is fine now. I think what remains it handling fpnew: It refers to a different common_cells version than we currently use, causing a conflict in ipapprox. Is this conflict also visible in bender? This pr should fix it https://github.com/pulp-platform/fpnew/pull/41

Edit: I guess bender doesn't have a problem because it follows semantic versioning rules when resolving the dependencies. Is this correct? @meggiman Maybe we need to patch in these rules into ipapprox too.

micprog commented 3 years ago

I added the updated tag for register_interface in this PR, so should be fine. Regarding common_cells, bender will automatically update according to semver, so if the version requirement is v1.20.0, it restricts to >=v1.20.0, <2.0.0, preferring newer versions if possible. This means that bender is compatible with updates and non-breaking mismatches, allowing each repo to list its dependencies without requiring everything to match perfectly. IPApproX is not as compatible, one of the reasons for updating.

I will update the fpnew reference once the fpnew PR is merged.