pulp-platform / riscv-dbg

RISC-V Debug Support for our PULP RISC-V Cores
Other
219 stars 72 forks source link

dm_csrs.resp_queue_pop set also when cmdbusy_i=1 #103

Open masgia opened 3 years ago

masgia commented 3 years ago

This is related to #37 : pull request #79 doesn't seem to fully solve the problem. I see that even if cmd_busy is set, an incoming request is immediately accepted and a word is popped from the FIFO. This results in the popped world being transferred nowhere. I am now wandering whether issuing resp_queue_pop only when cmdbusy_i=0 would solve the problem

-  assign resp_queue_pop = dmi_resp_ready_i & ~resp_queue_empty;
+  assign resp_queue_pop = dmi_resp_ready_i & ~resp_queue_empty & ~cmdbusy_i;

(tests ongoing)

msfschaffner commented 1 year ago

Can you check whether this issue is solved with #138? If yes, please close the issue.