search

pulp-platform / snitch_cluster

An energy-efficient RISC-V floating-point compute cluster.
https://pulp-platform.github.io/snitch_cluster/
Apache License 2.0
51 stars 51 forks source link

Add +define+COMMON_CELLS_ASSERTS_OFF #130

Closed franktaTian closed 6 months ago

franktaTian commented 6 months ago

Please add +define+COMMON_CELLS_ASSERTS_OFF in target/common/common.mk

Env. docker (main) Run.
cd /repo/target/snitch_cluster make bin/snitch_cluster.vlt Will report error ifndef COMMON_CELLS_ASSERTS_OFF for common cells.

colluca commented 6 months ago

Hi @franktaTian, do you mean what this line here is doing?

https://github.com/pulp-platform/snitch_cluster/blob/13d1e6b3aaa8e53d5b39858c6ee871b186bf9aa2/target/common/common.mk#L73

franktaTian commented 6 months ago

I added "VLT_FLAGS += +define+COMMON_CELLS_ASSERTS_OFF" in this file

Hi @franktaTian, do you mean what this line here is doing?

https://github.com/pulp-platform/snitch_cluster/blob/13d1e6b3aaa8e53d5b39858c6ee871b186bf9aa2/target/common/common.mk#L73

colluca commented 6 months ago

The line I quoted adds exactly the flag you mentioned to the flags in work-vlt/files, and this file is passed in the invocation of the verilator command (see -f option).

Also, the commands you mention are reproduced by the CI and they did not log any errors on the last run.

I will close this issue. Feel free to reopen if you have other details.