search

pulp / Pulp-2-Tests

:warning: ⛔️ Pulp2 is EOL as of November 30 2022, for more info visit this link https://pulpproject.org/2022/09/19/pulp-2-eol/. ⛔️ Functional tests for Pulp 2.
https://pulp-2-tests.readthedocs.io/
1 stars 11 forks source link

Remove redundant test to copy modular errata #183

Closed nixocio closed 5 years ago

nixocio commented 5 years ago

Remove redundant test to copy modular errata. This test was failing for 2.18.1, and the behavior was fixed on 2.19 series. When documentation was written the behavior that 2.18 series was asserting was not right.

See: https://github.com/PulpQE/Pulp-2-Tests/commit/1f78c0fa1be0269e8c9dc6b07a723afa22730279 Also: https://pulp.plan.io/issues/4371

bherrin3 commented 5 years ago

Review Notes

Verified Functionality for:

Additional Information

To expound a little more on the removal of the test, for posterity.

The PR that included test_upload_errata included a super-set of testing that deprecated test_copy_errata. The former test was also verifying incomplete knowledge and coverage of the feature (and the feature itself). This was proven to be true when the behavior was compared between 2.18. and 2.19 for the same feature. The behavior changed and the issue was uncovered and resolved in #182.

The test_upload_errata is removed while coverage for copying errata (uploading) has been improved. The resulting coverage for the feature in < 2.19 is irrelevant as the feature was not completely delivered.