Adding check for modular RPM upload is_modular tags

pulp / Pulp-2-Tests

:warning: ⛔️ Pulp2 is EOL as of November 30 2022, for more info visit this link https://pulpproject.org/2022/09/19/pulp-2-eol/. ⛔️ Functional tests for Pulp 2.

https://pulp-2-tests.readthedocs.io/

1 stars 11 forks source link

Adding check for modular RPM upload is_modular tags #201

Closed bherrin3 closed 5 years ago

bherrin3 commented 5 years ago

Problem

Issue #4869 updates the DISTAG check to a new backwards compatible check for is_modular for RPM uploads.

Updates

Adding verification for RPM uploads with and without is_modular to ensure the RPM tags are being read correctly.

Notes

RM 4869 is not yet merged
The test fixture RPM is current taken from the F30 Modular RPM repository.
Using a sane baseline to ensure the tests functions. Later updating the fixture to a self-built modular RPM, if possible (time).

References

closes #4930

nixocio commented 5 years ago

@bherrin3, as we talked lets suggest this PR to be run locally with the code related to the #4869. Before we merge in here, to avoid extra troubleshooting later on. Good job.

bherrin3 commented 5 years ago

@kersommoura ideally wait for #202 to merge before merging this one, please. :)

bherrin3 commented 5 years ago

@bherrin3, as we talked lets suggest this PR to be run locally with the code related to the #4869. Before we merge in here, to avoid extra troubleshooting later on. Good job.

Other issues were investigated and this helped with that investigation.

Source PR is now merged and this can be merged into CI and has been tested to function before merge.

bherrin3 commented 5 years ago

@kersommoura @rochacbruno re-based. It will now fail unless we rebuild the p2 RPMs with the CI job as the ticket is set to MODIFIED, but the RPMs will not have been built from 2-master until tonight

bherrin3 commented 5 years ago

Note: Just updated docstring meta that was inaccurate (removal of 1 line in constants).