search

pulp / Pulp-2-Tests

:warning: ⛔️ Pulp2 is EOL as of November 30 2022, for more info visit this link https://pulpproject.org/2022/09/19/pulp-2-eol/. ⛔️ Functional tests for Pulp 2.
https://pulp-2-tests.readthedocs.io/
1 stars 11 forks source link

Take copied modulemd_defaults into consideration for module errata copy #211

Closed dralley closed 5 years ago

dralley commented 5 years ago

re: #5055 https://pulp.plan.io/issues/5055

Dep: https://github.com/pulp/pulp_rpm/pull/1400

nixocio commented 5 years ago

@dralley, thank you for update the tests.

nixocio commented 5 years ago

Is there a specific version of Pulp that this change will be effective?

I am assuming any version after 2.20. We should add a logic to assure that this test does not fail in a earlier version of Pulp. Let me find an example.

nixocio commented 5 years ago

A minor suggestion is to update the docstring with the number of issue related to this change. This can be very helpful later on.

bherrin3 commented 5 years ago

Oh, and +1 @dralley for making these changes! Awesome job!

dralley commented 5 years ago

@kersommoura @bherrin3 Updated

bherrin3 commented 5 years ago

Ack a conversation with @dralley as he feels the parent PR (https://github.com/pulp/pulp_rpm/pull/1400) will be merged shortly.

Else we could update with the following, if there is a source Redmine Issue for XXXX and merge now.:

        if cls.cfg.pulp_version < Version('2.21'):
            raise unittest.SkipTest('This test requires Pulp 2.21 or newer.')
            if not selectors.bug_is_fixed(XXXX, cls.cfg.pulp_version):
                raise unittest.SkipTest('https://pulp.plan.io/issues/XXXX')
dralley commented 5 years ago

1400 merged

nixocio commented 5 years ago

@dralley, thanks.