pulp / oci_env

9 stars 33 forks source link

Revert "Revert "Add a section for building docs"" #108

Closed lubosmj closed 1 year ago

lubosmj commented 1 year ago

This reverts commit a30c5aaf3f3479983ec0bd663cdbb9e15b5dacae and fixes the docs port exposed to the world.

newswangerd commented 1 year ago

@lubosmj I'm gonna create a PR to fix the galaxy_ng ci for this change, then I'll merge this.

lubosmj commented 1 year ago

Is it still failing? Weird...

newswangerd commented 1 year ago

@lubosmj I think it will when this pr is merged. I have to update the sync test on our ci to use different ports for the docs service.

lubosmj commented 1 year ago

Okay, please use the NGINX_DOCS_PORT variable that is supposed to behave like NGINX_PORT.

lubosmj commented 1 year ago

@newswangerd, any update on your effort? Can we merge this PR?