search

pulp / plugin_template

GNU General Public License v2.0
8 stars 35 forks source link

Release branch creation workflow needs to require all parameters needed to update requirements.txt and GHA configs #419

Open dkliban opened 3 years ago

dkliban commented 3 years ago

The release workflow is changing the required pulpcore version in the commit that bumps the version of the plugin. The required version of pulpcore should not change.

daviddavis commented 3 years ago

I was imagining that the upper pulpcore version gets set when the release branch is created. And then never gets unset unless the plugin writer confirms that newer versions of pulpcore are compatible with their y-release branch.

mdellweg commented 3 years ago

I was imagining that the upper pulpcore version gets set when the release branch is created. And then never gets unset unless the plugin writer confirms that newer versions of pulpcore are compatible with their y-release branch.

Can this be accompanied with a check, that the release workflow cannot be started from the main branch?

dkliban commented 3 years ago

The initial bug report I wrote up does not actually exist. However, I would like to repurpose this issue to add a check that the release job can't be run on master branch.

stale[bot] commented 2 years ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!